linux-kernel - Re: [PATCH] fs/gfs2: use scnprintf() in show functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061623-hazelnut-blandness-9b03@gregkh>
Date: Mon, 16 Jun 2025 16:20:33 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Pranav Tyagi <pranav.tyagi03@...il.com>
Cc: agruenba@...hat.com, skhan@...uxfoundation.org, gfs2@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] fs/gfs2: use scnprintf() in show functions

On Mon, Jun 16, 2025 at 04:26:26PM +0530, Pranav Tyagi wrote:
> Replace all snprintf() instances with scnprintf(). snprintf() returns
> the number of bytes that would have been written had there been enough
> space. For sysfs attributes, snprintf() should not be used with the
> show() method. Instead use scnprintf() which returns the number of bytes
> actually written.
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>
> ---
>  fs/gfs2/sys.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

sysfs_emit() or no change at all please.