linux-kernel - Re: [PATCH] fs/ecryptfs: use scnprintf() in version show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061642-unaltered-antler-e6fa@gregkh>
Date: Mon, 16 Jun 2025 16:21:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Pranav Tyagi <pranav.tyagi03@...il.com>
Cc: code@...icks.com, brauner@...nel.org, sandeen@...hat.com,
	colin.i.king@...il.com, skhan@...uxfoundation.org,
	ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] fs/ecryptfs: use scnprintf() in version show

On Mon, Jun 16, 2025 at 04:11:20PM +0530, Pranav Tyagi wrote:
> Replace all snprintf() instances with scnprintf(). snprintf() returns
> the number of bytes that would have been written had there been enough
> space. For sysfs attributes, snprintf() should not be used for the
> show() method. Instead use scnprintf() which returns the number of
> bytes actually written.
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>
> ---
>  fs/ecryptfs/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 8dd1d7189c3b..2a97c2b1fc69 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -764,7 +764,7 @@ static struct kobject *ecryptfs_kobj;
>  static ssize_t version_show(struct kobject *kobj,
>  			    struct kobj_attribute *attr, char *buff)
>  {
> -	return snprintf(buff, PAGE_SIZE, "%d\n", ECRYPTFS_VERSIONING_MASK);
> +	return scnprintf(buff, PAGE_SIZE, "%d\n", ECRYPTFS_VERSIONING_MASK);

sysfs_emit() or no change at all please.