linux-kernel - Re: [PATCH] fs/dlm: use scnprintf() in lockspace show funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061659-sauciness-ravioli-ff59@gregkh>
Date: Mon, 16 Jun 2025 16:22:11 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Pranav Tyagi <pranav.tyagi03@...il.com>
Cc: aahringo@...hat.com, teigland@...hat.com, skhan@...uxfoundation.org,
	gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] fs/dlm: use scnprintf() in lockspace show funcs

On Mon, Jun 16, 2025 at 04:04:41PM +0530, Pranav Tyagi wrote:
> Replace all snprintf() instances with scnprintf(). snprintf() returns
> the number of bytes that would have been written had there been enough
> space. For sysfs attributes, snprintf() should not be used for the
> show() method. Instead use scnprintf() which returns the number of
> bytes actually written.
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>
> ---
>  fs/dlm/config.c    | 2 +-
>  fs/dlm/lockspace.c | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/dlm/config.c b/fs/dlm/config.c
> index a23fd524a6ee..10486a46a540 100644
> --- a/fs/dlm/config.c
> +++ b/fs/dlm/config.c
> @@ -185,7 +185,7 @@ static ssize_t cluster_##name##_store(struct config_item *item, \
>  }                                                                             \
>  static ssize_t cluster_##name##_show(struct config_item *item, char *buf)     \
>  {                                                                             \
> -	return snprintf(buf, PAGE_SIZE, "%u\n", dlm_config.ci_##name);        \
> +	return scnprintf(buf, PAGE_SIZE, "%u\n", dlm_config.ci_##name);       \

sysfs_emit() or no change at all please.