linux-kernel - Re: [PATCH v4 4/5] scsi: fnic: Turn off FDMI ACTIVE flags on link down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cf23067-de70-45b9-ad83-90e96c5ea189@redhat.com>
Date: Mon, 16 Jun 2025 10:35:39 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
 "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
Cc: "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
 "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
 "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
 "Masa Kai (mkai2)" <mkai2@...co.com>,
 "Satish Kharat (satishkh)" <satishkh@...co.com>,
 "Arun Easi (aeasi)" <aeasi@...co.com>,
 "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
 "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
 "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "revers@...hat.com" <revers@...hat.com>,
 "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v4 4/5] scsi: fnic: Turn off FDMI ACTIVE flags on link
 down

Sounds good to me. Please make these changes in your v5 patch series and I'll approve.

/John

On 6/13/25 5:59 PM, Karan Tilak Kumar (kartilak) wrote:
> On Friday, June 13, 2025 1:29 PM, John Meneghini <jmeneghi@...hat.com> wrote:
>>
>> Hi Karan.
>>
>> You've got two patches in this series with the same Fixes: tag.
>>
>> [PATCH v4 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out
>> Fixes: 09c1e6ab4ab2 ("scsi: fnic: Add and integrate support for FDMI")
>>
>> [PATCH v4 4/5] scsi: fnic: Turn off FDMI ACTIVE flags on link down
>> Fixes: 09c1e6ab4ab2 ("scsi: fnic: Add and integrate support for FDMI")
>>
>> both of these patches modify the same file:
>>
>> drivers/scsi/fnic/fdls_disc.c
>>
>> So I recommend you squash patch 4/5 and patch 2/5 into one.
>>
>> Thanks,
>>
>> /John
> 
> Thanks for your proposal, John.
> 
> I'm a bit hesitant to squash them into one since each patch fixes unrelated bugs.
> The reason they have the same fixes tag is because we found two separate issues in the same commit.
> 
> I get your concern, however. What do you think about the following?
> 
> Move this patch to the beginning and increment driver version to 1.8.0.1:
> [PATCH v4 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out
> 
> Move this patch to the next and increment driver version to 1.8.0.2:
> [PATCH v4 4/5] scsi: fnic: Turn off FDMI ACTIVE flags on link down
> 
> Move this patch to the next:
> [PATCH v4 3/5] scsi: fnic: Add and improve logs in FDMI and FDMI ABTS paths
> 
> Ideally, I would have liked to squash this above patch with the first patch in this series, since it's easier to debug if and when an issue occurs in that path.
> I separated them since it would be easier to review. I could add a Fixes tag here as well, but I'm not sure about that since they are just log messages,
> and they are not really fixes.
> 
> Move this patch to the end:
> [PATCH v4 1/5] scsi: fnic: Set appropriate logging level for log message
> 
> Regards,
> Karan
>