linux-kernel - Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a76789cf-afe1-4d91-afdf-65c3af5ad11f@kernel.org>
Date: Mon, 16 Jun 2025 16:41:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jorge Ramirez <jorge.ramirez@....qualcomm.com>
Cc: quic_vgarodia@...cinc.com, quic_dikshita@...cinc.com,
 bryan.odonoghue@...aro.org, mchehab@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, stanimir.varbanov@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema

On 16/06/2025 14:52, Jorge Ramirez wrote:
>>
>>> +  The Venus AR50_LITE IP is a video encode and decode accelerator present
>>> +  on Qualcomm platforms
>>> +
>>> +allOf:
>>> +  - $ref: qcom,venus-common.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: qcom,qcm2290-venus
>>> +
>>> +  power-domains:
>>> +    minItems: 2
>>> +    maxItems: 3
>>> +
>>> +  power-domain-names:
>>> +    minItems: 2
>>
>> Why is this flexible? Either you have two or three. Not mixed.
> 
> please check 5b380f242f360256c96e96adabeb7ce9ec784306

This does not explain why this is optional HERE. You cannot use for a
new platform an argument that some existing platform was changed in
ABI-preserving way.

BTW, also subject prefixes needs fixing. For DTS: it is never "arch".
For this patch: wrong order (see DT submitting patches).

Best regards,
Krzysztof