linux-kernel - Re: RE: [PATCH v14 00/32] fs,x86/resctrl: Support AMD Assignable Bandwidth Monitoring Counters (ABMC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d50ce593-a324-4b08-ae13-2264a41ebc6b@amd.com>
Date: Mon, 16 Jun 2025 09:47:35 -0500
From: "Moger, Babu" <babu.moger@....com>
To: "Luck, Tony" <tony.luck@...el.com>, "corbet@....net" <corbet@....net>,
 "Chatre, Reinette" <reinette.chatre@...el.com>,
 "Dave.Martin@....com" <Dave.Martin@....com>,
 "james.morse@....com" <james.morse@....com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
Cc: "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "paulmck@...nel.org" <paulmck@...nel.org>,
 "thuth@...hat.com" <thuth@...hat.com>, "ardb@...nel.org" <ardb@...nel.org>,
 "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "seanjc@...gle.com" <seanjc@...gle.com>,
 "thomas.lendacky@....com" <thomas.lendacky@....com>,
 "pawan.kumar.gupta@...ux.intel.com" <pawan.kumar.gupta@...ux.intel.com>,
 "manali.shukla@....com" <manali.shukla@....com>,
 "perry.yuan@....com" <perry.yuan@....com>, "Huang, Kai"
 <kai.huang@...el.com>, "peterz@...radead.org" <peterz@...radead.org>,
 "Li, Xiaoyao" <xiaoyao.li@...el.com>,
 "kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>,
 "mario.limonciello@....com" <mario.limonciello@....com>,
 "Li, Xin3" <xin3.li@...el.com>,
 "gautham.shenoy@....com" <gautham.shenoy@....com>,
 "xin@...or.com" <xin@...or.com>, "Bae, Chang Seok"
 <chang.seok.bae@...el.com>, "fenghuay@...dia.com" <fenghuay@...dia.com>,
 "peternewman@...gle.com" <peternewman@...gle.com>,
 "Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>,
 "Eranian, Stephane" <eranian@...gle.com>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: RE: [PATCH v14 00/32] fs,x86/resctrl: Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)

Hi Tony,

On 6/13/25 16:41, Luck, Tony wrote:
> Babu,
> 
> Compiling with "make W=1" you have several kerneldoc comments on new functions
> that do not describe their parameters.
> 
> E.g.
> 
> /**
>  * resctrl_config_cntr() - Configure the counter ID for the event, RMID pair in
>  * the domain.
>  *
>  * Assign the counter if @assign is true else unassign the counter. Reset the
>  * associated non-architectural state.
>  */
> static void resctrl_config_cntr(struct rdt_resource *r, struct rdt_mon_domain *d,
>                                 enum resctrl_event_id evtid, u32 rmid, u32 closid,
>                                 u32 cntr_id, bool assign)
> 
> 
> Warning: fs/resctrl/monitor.c:984 function parameter 'r' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'd' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'evtid' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'rmid' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'closid' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'cntr_id' not described in 'resctrl_config_cntr'
> Warning: fs/resctrl/monitor.c:984 function parameter 'assign' not described in 'resctrl_config_cntr'
>

Yes. I noticed several of them.
Warning goes away after replacing "/**" with "/*".

Now I am not sure if we fix it with replacing with "/*"  or adding
definitions for each of these parameters. There will be too many
repetitions. All these functions take r, d, eventid, and rmid as
parameters. Also these are static functions.
-- 
Thanks
Babu Moger