linux-kernel - Re: [PATCH v6 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250616-zealous-scariness-48b47a0818a5@spud>
Date: Mon, 16 Jun 2025 16:03:04 +0100
From: Conor Dooley <conor@...nel.org>
To: Johan Adolfsson <johan.adolfsson@...s.com>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH v6 2/2] dt-bindings: leds: lp50xx: Document child reg,
 fix example

On Mon, Jun 16, 2025 at 01:25:35PM +0200, Johan Adolfsson wrote:
> The led child reg node is the index within the bank, document that
> and update the example accordingly.
> 
> Signed-off-by: Johan Adolfsson <johan.adolfsson@...s.com>
> ---
>  .../devicetree/bindings/leds/leds-lp50xx.yaml       | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index 402c25424525..cb450aed718c 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -81,7 +81,14 @@ patternProperties:
>  
>          properties:
>            reg:
> -            maxItems: 1
> +            items:
> +              - minimum: 0
> +                maximum: 2
> +
> +            description:
> +              This property denotes the index within the LED bank.

> +              The value will act as the index in the multi_index file to give
> +              consistent result independent of devicetree processing order.

This looks like commentary on the particulars of the driver
implementation in linux, which shouldn't be in a binding.

>  
>          required:
>            - reg
> @@ -138,18 +145,18 @@ examples:
>                  color = <LED_COLOR_ID_RGB>;
>                  function = LED_FUNCTION_STANDBY;
>  
> -                led@3 {
> -                    reg = <0x3>;
> +                led@0 {
> +                    reg = <0x0>;

Do you have any explanation for why these numbers, outside the range you
said is valid, were in the binding's example?
Additionally, can you mention in the commit message what the source was
for the 0-2 range?

Cheers,
Conor.

>                      color = <LED_COLOR_ID_RED>;
>                  };
>  
> -                led@4 {
> -                    reg = <0x4>;
> +                led@1 {
> +                    reg = <0x1>;
>                      color = <LED_COLOR_ID_GREEN>;
>                  };
>  
> -                led@5 {
> -                    reg = <0x5>;
> +                led@2 {
> +                    reg = <0x2>;
>                      color = <LED_COLOR_ID_BLUE>;
>                  };
>              };
> 
> -- 
> 2.30.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)