linux-kernel - Re: [PATCH net-next v2 3/5] netconsole: append msgid to sysdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGSyskU4Hh8qebN6KhVjFZXsPr3A5At7gAtm9wipnEZbiZZ+9g@mail.gmail.com>
Date: Mon, 16 Jun 2025 17:07:28 +0100
From: Gustavo Luiz Duarte <gustavold@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Breno Leitao <leitao@...ian.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>, 
	Jonathan Corbet <corbet@....net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/5] netconsole: append msgid to sysdata

On Sat, Jun 14, 2025 at 8:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 12 Jun 2025 13:02:16 -0700 Gustavo Luiz Duarte wrote:
> > diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> > index 3bf8777fcd01..baa9862c1bc3 100644
> > --- a/drivers/net/netconsole.c
> > +++ b/drivers/net/netconsole.c
> > @@ -155,6 +155,8 @@ struct netconsole_target {
> >       size_t                  userdata_length;
> >       /* bit-wise with sysdata_feature bits */
> >       u32                     sysdata_fields;
> > +     /* protected by target_list_lock */
> > +     u32                     msgcounter;
> >  #endif
>
> kdoc is complaining that:
>
> drivers/net/netconsole.c:167 struct member 'msgcounter' not described in 'netconsole_target'

Good catch. I'm sending v3 to fix this (will also add kdoc check to my
pre-send checklist).
Thanks for the review!