linux-kernel - Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e15f4d39-379d-436f-b401-36f5b3f6f010@kernel.org>
Date: Mon, 16 Jun 2025 18:26:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>, marcel@...tmann.org,
 luiz.dentz@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, amitkumar.karwar@....com, sherry.sun@....com,
 manjeet.gupta@....com
Subject: Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for
 4M baudrate

On 16/06/2025 17:09, Neeraj Sanjay Kale wrote:
> Add support for 4000000 as secondary baudrate for downloading FW chunks and
> after HCI initialization is done at fw-init-baudrate.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
>  .../bindings/net/bluetooth/nxp,88w8987-bt.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 3ab60c70286f..f1c7f900001c 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -34,6 +34,16 @@ properties:
>        This property depends on the module vendor's
>        configuration.
>  
> +  secondary-baudrate:
> +    $ref: /schemas/types.yaml#/definitions/uint32

baudrate is in some value, so use unit suffix from property-units and
drop the ref.

And then you will see that it could be actually an array, so why not
using existing properties? Otherwise you will add soon "tertiary" etc?
This does not scale.

Best regards,
Krzysztof