linux-kernel - [PATCH 1/2] memory: tegra-mc: add tracepoints for tegra mc tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250616160103.2105041-2-ben.dooks@codethink.co.uk>
Date: Mon, 16 Jun 2025 17:01:02 +0100
From: Ben Dooks <ben.dooks@...ethink.co.uk>
To: thierry.reding@...il.com,
	jonathanh@...dia.com,
	rostedt@...dmis.org,
	mhiramat@...nel.org,
	linux-tegra@...r.kernel.org
Cc: linux-trace-kernel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: [PATCH 1/2] memory: tegra-mc: add tracepoints for tegra mc tracing

Add trace points to allow tracing of how the tegra_mc driver is being
called.

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
 drivers/memory/tegra/mc.c       | 26 +++++++------
 include/trace/events/tegra_mc.h | 69 +++++++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+), 11 deletions(-)
 create mode 100644 include/trace/events/tegra_mc.h

diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index bd5b58f1fd42..256cf0d0aa2d 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -21,6 +21,9 @@
 
 #include "mc.h"
 
+#define CREATE_TRACE_POINTS
+#include <trace/events/tegra_mc.h>
+
 static const struct of_device_id tegra_mc_of_match[] = {
 #ifdef CONFIG_ARCH_TEGRA_2x_SOC
 	{ .compatible = "nvidia,tegra20-mc-gart", .data = &tegra20_mc_soc },
@@ -210,6 +213,8 @@ static int tegra_mc_hotreset_assert(struct reset_controller_dev *rcdev,
 	int retries = 500;
 	int err;
 
+	trace_tegra_mc_hotreset(mc->dev, id, true);
+
 	rst = tegra_mc_reset_find(mc, id);
 	if (!rst)
 		return -ENODEV;
@@ -269,6 +274,8 @@ static int tegra_mc_hotreset_deassert(struct reset_controller_dev *rcdev,
 	const struct tegra_mc_reset *rst;
 	int err;
 
+	trace_tegra_mc_hotreset(mc->dev, id, false);
+
 	rst = tegra_mc_reset_find(mc, id);
 	if (!rst)
 		return -ENODEV;
@@ -583,7 +590,7 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 	for_each_set_bit(bit, &status, 32) {
 		const char *error = tegra_mc_status_names[bit] ?: "unknown";
 		const char *client = "unknown", *desc;
-		const char *direction, *secure;
+		bool secure, write;
 		u32 status_reg, addr_reg;
 		u32 intmask = BIT(bit);
 		phys_addr_t addr = 0;
@@ -652,15 +659,8 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 		}
 #endif
 
-		if (value & MC_ERR_STATUS_RW)
-			direction = "write";
-		else
-			direction = "read";
-
-		if (value & MC_ERR_STATUS_SECURITY)
-			secure = "secure ";
-		else
-			secure = "";
+		write = value & MC_ERR_STATUS_RW;
+		secure = value & MC_ERR_STATUS_SECURITY;
 
 		id = value & mc->soc->client_id_mask;
 
@@ -710,8 +710,12 @@ irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
 			value = mc_readl(mc, addr_reg);
 		addr |= value;
 
+		trace_tegra_mc_err(mc->dev, client, secure, write, addr,
+				   error, desc, perm);
+
 		dev_err_ratelimited(mc->dev, "%s: %s%s @%pa: %s (%s%s)\n",
-				    client, secure, direction, &addr, error,
+				    client, secure ? "secure" : "",
+				    write ? "write" : "read", &addr, error,
 				    desc, perm);
 	}
 
diff --git a/include/trace/events/tegra_mc.h b/include/trace/events/tegra_mc.h
new file mode 100644
index 000000000000..acf00a19240b
--- /dev/null
+++ b/include/trace/events/tegra_mc.h
@@ -0,0 +1,69 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* tegra memory controller tracepoints
+ *
+ * Copyright (c) 2025 Codethink Ltd.
+ * Ben Dooks <ben.dooks@...ethink.co.uk>
+ */
+
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM tegra_mc
+
+#if !defined(_TRACE_TEGRA_MC_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_TEGRA_MC_H
+
+#include <linux/device.h>
+#include <linux/tracepoint.h>
+
+TRACE_EVENT(tegra_mc_hotreset,
+	    TP_PROTO(struct device *dev, unsigned long id, bool assert),
+	    TP_ARGS(dev, id, assert),
+	    TP_STRUCT__entry(
+			     __string(dev, dev_name(dev))
+			     __field(unsigned long, id)
+			     __field(bool, assert)),
+	    TP_fast_assign(
+			   __assign_str(dev);
+			   __entry->id = id;
+			   __entry->assert = assert;
+			   ),
+	    TP_printk("rcdev %s, id %lu, %s\n",
+		      __get_str(dev), __entry->id, __entry->assert ? "assert" : "release")
+);
+
+TRACE_EVENT(tegra_mc_err,
+	    TP_PROTO(struct device *dev, const char *client,
+		     bool secure, bool write, phys_addr_t addr,
+		     const char *error, const char *desc, const char *perm),
+	    TP_ARGS(dev, client, secure, write, addr, error, desc, perm),
+	    TP_STRUCT__entry(
+			     __string(dev,		dev_name(dev))
+			     __field(const char *,	client)
+			     __field(bool, secure)
+			     __field(bool, write)
+			     __field(phys_addr_t, addr)
+			     __field(const char *, error)
+			     __field(const char *, desc)
+			     __string(perm, perm)),
+	    TP_fast_assign(
+			   __assign_str(dev);
+			   __entry->client = client;
+			   __entry->secure = secure;
+			   __entry->write = write;
+			   __entry->addr = addr;
+			   __entry->desc = desc;
+			   __assign_str(perm);
+			   ),
+	    TP_printk("%s: %s: %s%c @%pa %s (%s%s)",
+		      __get_str(dev),
+		      __entry->client, __entry->secure ? "secure/" : "",
+		      __entry->write ? 'w' : 'r',
+		      &__entry->addr,
+		      __entry->error,
+		      __entry->desc,
+		      __get_str(perm))
+);
+
+#endif /* _TRACE_TEGRA_MC_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
-- 
2.37.2.352.g3c44437643