linux-kernel - Re: [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86plf3d3jv.wl-maz@kernel.org>
Date: Mon, 16 Jun 2025 18:00:52 +0100
From: Marc Zyngier <maz@...nel.org>
To: Wei-Lin Chang <r09922117@...e.ntu.edu.tw>
Cc: linux-arm-kernel@...ts.infradead.org,
	kvmarm@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Oliver Upton <oliver.upton@...ux.dev>,
	Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Jintack Lim <jintack@...columbia.edu>,
	Christoffer Dall <christoffer.dall@....com>
Subject: Re: [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put_nested()

On Mon, 16 Jun 2025 15:34:58 +0100,
Wei-Lin Chang <r09922117@...e.ntu.edu.tw> wrote:
> 
> On Mon, Jun 16, 2025 at 11:54:57AM +0100, Marc Zyngier wrote:
>
> > +static u64 translate_lr_hw_bit(struct kvm_vcpu *vcpu, u64 lr)
> 
> I believe translate_lr_pintid() better describes what this function is
> doing.

Ah, you too noticed that I am terrible at naming things? ;-)

Agreed, this is a better name, and I'll gladly apply your suggestion.

> 
> For everything else, I don't spot any issues after review.
> 
> Reviewed-by: Wei-Lin Chang <r09922117@...e.ntu.edu.tw>

Thanks again!

	M.

-- 
Without deviation from the norm, progress is not possible.