linux-kernel - Re: [RFC PATCH] ACPI / sysfs: Replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4euirck7yxqxlnzfwus7xfhpxre5q7ck5nhumvj7vdw2ha35mm@dtrhqeyl5tob>
Date: Mon, 16 Jun 2025 23:22:15 +0530
From: Brahmajit Das <listout@...tout.xyz>
To: linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	lv.zheng@...el.com
Subject: Re: [RFC PATCH] ACPI / sysfs: Replace deprecated strcpy() with
 strscpy()

On 16.06.2025 23:17, Brahmajit Das wrote:
...
> ---
>  drivers/acpi/sysfs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index a48ebbf768f9..4005c9faf14f 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -181,10 +181,9 @@ static int param_set_trace_method_name(const char *val,
>  
>  	/* This is a hack.  We can't kmalloc in early boot. */
>  	if (is_abs_path)
> -		strcpy(trace_method_name, val);
> +		strscpy(trace_method_name, val);
>  	else {
> -		trace_method_name[0] = '\\';
> -		strcpy(trace_method_name+1, val);
> +		scnprintf(trace_method_name, sizeof(trace_method_name), "%c%s", '\\', val);

Maybe something like would be better
 -		trace_method_name[0] = '\\';
 -		strcpy(trace_method_name+1, val);
 +		scnprintf(trace_method_name, sizeof(trace_method_name+1), "%c%s", '\\', val);

-- 
Regards,
listout