linux-kernel - Re: [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250616151848.36ddcee5@batman.local.home>
Date: Mon, 16 Jun 2025 15:18:48 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-xfs@...r.kernel.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Carlos  Maiolino
 <cem@...nel.org>, Christoph Hellwig <hch@....de>, "Darrick J. Wong"
 <djwong@...nel.org>
Subject: Re: [PATCH v2 00/13] xfs: tracing: remove unused event
 xfs_reflink_cow_found

Bah, I hate the multiple clipboards of the Linux desktop. I had cut and
pasted the above subject line in one clipboard and then cut the subject
I wanted in another, and unfortunately pasted the former :-p

This is what the subject was supposed to be:

  "xfs: remove unused trace events"

On Mon, 16 Jun 2025 13:51:46 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> Trace events take up to 5K in memory for text and meta data. I have code that
> will trigger a warning when it detects unused tracepoints[1]. The XFS file
> system contains many events that are not called. Most of them used to be called
> but due to code refactoring the calls were removed but the trace events stayed
> behind.
> 
> Some events were added but never used. If they were recent, I just reported
> them, but if they were older, this series simply removes them.
> 
> One is called only when CONFIG_COMPACT is defined, so an #ifdef was placed
> around it.
> 
> Finally, one event is supposed to be a trace event class, but was created with
> the TRACE_EVENT() macro and not the DECLARE_EVENT_CLASS() macro. This works
> because a TRACE_EVENT() is simply a DECLARE_EVENT_CLASS() and DEFINE_EVENT()
> where the class and event have the same name. But as this was a mistake, the
> event created should not exist.
> 
> [1] https://patchwork.kernel.org/project/linux-trace-kernel/cover/20250612235827.011358765@goodmis.org/
> 
> Changes since v1: https://lore.kernel.org/linux-trace-kernel/20250612212405.877692069@goodmis.org/

And this should have been to the lore link and not patchwork:

  https://lore.kernel.org/linux-trace-kernel/20250612235827.011358765@goodmis.org/

-- Steve