linux-kernel - Re: [PATCH v7] rust: transmute: Add methods for FromBytes trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABm2a9fVSGm+WWjdkAmJHUH9eH=Qx5efORKxyJtt0HnQrs0QHQ@mail.gmail.com>
Date: Mon, 16 Jun 2025 17:07:54 -0300
From: Christian <christiansantoslima21@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ~lkcamp/patches@...ts.sr.ht, 
	richard120310@...il.com
Subject: Re: [PATCH v7] rust: transmute: Add methods for FromBytes trait

Hi, Miguel

> Please start with something like "Add methods ... and ... They are
> useful to ...", i.e. the idea is to try to explain the "what" and the
> "why" (what is being added, and why is it being added).

I see, sorry.

> > Signed-off-by: Every2 <christiansantoslima21@...il.com>
>
> The previous version used your name in the SoB -- is this expected?

Not at all, I checked and my git config was messy. In the next patch
everything should be fine. Thanks for the feedback

> Can we do the cast earlier and then use `.is_aligned()` instead?

Of course.

> Also, since this is inside a macro, we should try to avoid assuming
> anything about the caller's code, so please use `::core` instead of
> `core`.

I noticed that core is used in other places, is it worth using as
default dependency since other people use it and reduce verbosity of
the code?

> Also, this is still missing safety comments on top of a couple
> `unsafe` blocks (pointed out in an earlier version). Are you building
> with `make ..... CLIPPY=1`?

No, but I'll activate it now, Thanks for the valuable feedback!

Cheers,
Christian