linux-kernel - Re: [PATCH 2/2] dmaengine: qcom_hidma: fix handoff FIFO memory leak on driver removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fb982e6-7184-410e-94d0-90836c2a9129@kernel.org>
Date: Mon, 16 Jun 2025 17:59:44 -0400
From: Sinan Kaya <Okaya@...nel.org>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: Eugen Hristev <eugen.hristev@...aro.org>, Vinod Koul <vkoul@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: qcom_hidma: fix handoff FIFO memory leak
 on driver removal

On 6/15/2025 3:15 PM, Qasim Ijaz wrote:
> Thanks for reviewing the patch and for pointing out the correct
> shutdown ordering.
>
> If you’re both happy with it, I’ll send a v2 that calls
> tasklet_disable() before tasklet_kill(), then frees the handoff_fifo.
>
> Just let me know and I’ll resend.

Sure, please test it on a test kernel module before posting with a tasklet.

This should be straightforward to verify.