linux-kernel - Re: [PATCH] mfd: rohm-bd71828: Constify some structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ff51253-d7fd-46c7-9cb9-b0af54120230@gmail.com>
Date: Mon, 16 Jun 2025 08:59:29 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: rohm-bd71828: Constify some structures

On 15/06/2025 19:32, Christophe JAILLET wrote:
> Several structures are not modified in this driver. Constifying them moves
> some data to a read-only section, so increases overall security, especially
> when the structure holds some function pointers. This is the case for
> 'gpio_keys_platform_data' and 'mfd_cell'.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>    18161	  14112	    192	  32465	   7ed1	drivers/mfd/rohm-bd71828.o
> 
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>    22897	   9376	    192	  32465	   7ed1	drivers/mfd/rohm-bd71828.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

Thanks!