linux-kernel - Re: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2ca2f58-f648-43f9-8d23-4111e4eb1f1d@kernel.org>
Date: Mon, 16 Jun 2025 08:43:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Nishanth Menon <nm@...com>,
 "nfraprado@...labora.com" <nfraprado@...labora.com>,
 Taniya Das <quic_tdas@...cinc.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
 Eric Biggers <ebiggers@...gle.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "soc@...ts.linux.dev" <soc@...ts.linux.dev>, Mo Elbadry
 <elbadrym@...gle.com>, Rom Lemarchand <romlem@...gle.com>,
 William Kennington <wak@...gle.com>, Yuxiao Zhang <yuxiaozhang@...gle.com>,
 "wthai@...dia.com" <wthai@...dia.com>, "leohu@...dia.com"
 <leohu@...dia.com>, "dkodihalli@...dia.com" <dkodihalli@...dia.com>,
 "spuranik@...dia.com" <spuranik@...dia.com>
Subject: Re: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device
 tree

On 16/06/2025 08:32, Ryan Chen wrote:
>>>
>>> But I don't know your previous "NAK, never tested" mean.
>>> I did make CHECK_DTBS=y arch/arm64/boot/dts/aspeed/ don't see the fail
>>> with
>>> intc0: interrupt-controller@...00000 {
>>> 	compatible = "simple-mfd";
>>>
>>> So, could you point me more test instruction for this?
>> See syscon.yaml. And writing bindings or talks on conferences:
>> simple-mfd cannot be alone.
>>
> 
>         intc0: interrupt-controller@...00000 {
> Sorry, do you mean add by following? 
> 				 compatible = "aspeed,intc-controller", "simple-mfd";
>  					.....
>                  intc0_11: interrupt-controller@...0 {
> 					compatible = "aspeed,ast2700-intc-ic";
>  					......
>                  };
>          };

Maybe, but you said this is base address, so how can it be some separate
device?

I mean really, don't add fake nodes just to satisfy some device
instantiation. Describe what this really is. That is the job of DTS. Not
some fake nodes.

Best regards,
Krzysztof