linux-kernel - RE: Of mei suspend/resume unused irq code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366E9288400660CC23AA8A8ED70A@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Mon, 16 Jun 2025 06:49:58 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>, "wentong.wu@...el.com"
	<wentong.wu@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Of mei suspend/resume unused irq code

> Subject: Of mei suspend/resume unused irq code
> 
> Hi,
>   My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> were unused, since your:
> 
> commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> system suspend/resume")
> 
> they were only added just before that one, in the patch that fixes;
> so I wondered whether those should be deleted as well?
> 
> (I've been doing unused function deleting - but don't normally do
> recent ones, so thought I'd ask).

It looks like the oversight while removing actual HW operations from
suspend /resume flow.
These functions can be safely removed.

- - 
Thanks,
Sasha


> 
> Dave
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/