linux-kernel - Re: [PATCH] kernel/entry: Fix misleading comment in irqentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87msa8noyn.ffs@tglx>
Date: Mon, 16 Jun 2025 09:08:16 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Khalid Ali <khaliidcaliy@...il.com>, peterz@...radead.org,
 luto@...nel.org, linux-kernel@...r.kernel.org
Cc: Khalid Ali <khaliidcaliy@...il.com>
Subject: Re: [PATCH] kernel/entry: Fix misleading comment in irqentry_enter()

On Sat, Jun 14 2025 at 19:26, Khalid Ali wrote:
> Change irqentry_enter_from_user_mode() to enter_from_user_mode(),
> because enter_from_user_mode() function is the one doing the action 
> comment indicates.

irqentry_enter_from_user_mode() is what is called in the user entry
branch, so the comment is not misleading at all. If someone can't follow
that function and figure out that it calls enter_from_user_mode() so be
it.

Thanks,

        tglx