linux-kernel - Re: [PATCH] ALSA: hda/realtek: Fixup ft alc257 rename alc3328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frg0p1fr.wl-tiwai@suse.de>
Date: Mon, 16 Jun 2025 09:53:28 +0200
From: Takashi Iwai <tiwai@...e.de>
To: wangdicheng <wangdich9700@....com>
Cc: lgirdwood@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com,
	linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org,
	wangdicheng <wangdicheng@...inos.cn>
Subject: Re: [PATCH] ALSA: hda/realtek: Fixup ft alc257 rename alc3328

On Mon, 16 Jun 2025 09:45:20 +0200,
wangdicheng wrote:
> 
> Audio ALC3328 recognized as ALC257, updated PCI ID0x10EC12F0 to rename it to 3328
> 
> Signed-off-by: wangdicheng <wangdicheng@...inos.cn>

Try to fix up via either rename_tbl[] or rename_pci_tbl[] instead.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index d3c9ed963588..e18b2a2acba8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6712,6 +6712,13 @@ static void alc_fixup_disable_mic_vref(struct hda_codec *codec,
>  		snd_hda_codec_set_pin_target(codec, 0x19, PIN_VREFHIZ);
>  }
>  
> +static void alc_fixup_ft_alc257_rename(struct hda_codec *codec,
> +                                 const struct hda_fixup *fix, int action)
> +{
> +       int err;
> +       if (action == HDA_FIXUP_ACT_PRE_PROBE)
> +               err = alc_codec_rename(codec, "ALC3328");
> +}
>  
>  static void alc294_gx502_toggle_output(struct hda_codec *codec,
>  					struct hda_jack_callback *cb)
> @@ -7799,6 +7806,7 @@ enum {
>  	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
>  	ALC233_FIXUP_MEDION_MTL_SPK,
>  	ALC294_FIXUP_BASS_SPEAKER_15,
> +	ALC257_FIXUP_FT_RENAME,
>  };
>  
>  /* A special fixup for Lenovo C940 and Yoga Duet 7;
> @@ -10143,6 +10151,10 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc294_fixup_bass_speaker_15,
>  	},
> +	[ALC257_FIXUP_FT_RENAME] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_ft_alc257_rename,
> +	},
>  };
>  
>  static const struct hda_quirk alc269_fixup_tbl[] = {
> @@ -10715,6 +10727,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x10cf, 0x1757, "Lifebook E752", ALC269_FIXUP_LIFEBOOK_HP_PIN),
>  	SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC),
>  	SND_PCI_QUIRK(0x10ec, 0x10f2, "Intel Reference board", ALC700_FIXUP_INTEL_REFERENCE),
> +	SND_PCI_QUIRK(0x10ec, 0x12f0, "BXC NF271B FT board", ALC257_FIXUP_FT_RENAME),
>  	SND_PCI_QUIRK(0x10ec, 0x118c, "Medion EE4254 MD62100", ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x10ec, 0x119e, "Positivo SU C1400", ALC269_FIXUP_ASPIRE_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x10ec, 0x11bc, "VAIO VJFE-IL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> -- 
> 2.25.1
>