linux-kernel - Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable PM8010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c850205-0c42-4e6d-bf5f-f1255367d53a@linaro.org>
Date: Mon, 16 Jun 2025 09:09:07 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Aleksandrs Vinarskis <alex.vinarskis@...il.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: bjorn.andersson@....qualcomm.com, Konrad Dybcio <konradybcio@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jens Glathe <jens.glathe@...schoolsolutions.biz>, laurentiu.tudor1@...l.com
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable
 PM8010

On 15/06/2025 19:29, Aleksandrs Vinarskis wrote:
> Hi all,
> 
> 
> Revisiting this change in context of Dell XPS 9345 and now Lenovo 
> ThinkBook 16 [1] (and upcoming Lenovo Ideapad 5) as these do not have 
> pm8010.
> 
> 
> Perhaps safest and easiest is to simply disable pm8010 in `x1e80100- 
> pmics.dtsi` as proposed and _not_ enable it on any devices, since its 
> known to not be used anywhere _yet_? As its a camera PMIC, the only 
> submitted upstream (did not land yet) change that utilizes pm8010 on X1/ 
> X1E is Bryan's CAMSS series that enables camera on CRD [2]. There are a 
> few other laptops that have patches to enable the camera (my Zenbook, 
> Bryan's branch on Gitlab for few more laptops) but those were not 
> submitted yet, so can be easily changed to explicitly enable pm8010 
> before submission. This way we could simplify this change and not have 
> to figure out which of the upstream devices do in fact have pm8010 onboard.

As a general principle, unless its used it should be disabled.

pm8010 is a camera specific PMIC and Dell has its own way of powering 
the camera sensors on XPS, Inspiron and I'd guess other models too, 
presumably as a result of reusing the x86 design with Qcom with minimal 
changes.

Disable by default. +1

---
bod