linux-kernel - Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aE_b5X7NmOd5-SC5@kernel.org>
Date: Mon, 16 Jun 2025 11:55:01 +0300
From: Mike Rapoport <rppt@...nel.org>
To: David Hildenbrand <david@...hat.com>
Cc: Hao Ge <hao.ge@...ux.dev>, Andrew Morton <akpm@...ux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Richard Henderson <richard.henderson@...aro.org>,
	Matt Turner <mattst88@...il.com>, Dennis Zhou <dennis@...nel.org>,
	Tejun Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Kent Overstreet <kent.overstreet@...ux.dev>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
	linux-s390@...r.kernel.org, Hao Ge <gehao@...inos.cn>
Subject: Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic
 for s390/alpha architectures

On Mon, Jun 16, 2025 at 09:59:09AM +0200, David Hildenbrand wrote:
> On 16.06.25 04:29, Hao Ge wrote:
> > From: Hao Ge <gehao@...inos.cn>
> 
> subject is misleading: we are not optimizing anything in this patch, do we?
> 
> It should probably be called
> 
> "mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or
> sth. like that.
> 
> 
> > Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file
> > and enable it for the s390 and alpha architectures.
> > And replace all instances of ARCH_NEEDS_WEAK_PER_CPU
> > in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.
> 
> Most of the description here should likely go to patch #2. See below.

...

> So what you could do is move the actual introduction of
> CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and
> limit this patch to the rename.
> 
> Similarly, teak the patch description to reflect only that.

Right, if the patch only renames ARCH_NEEDS_WEAK_PER_CPU to
MODULE_NEEDS_WEAK_PER_CPU the description can be as simple as 

mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU

as a preparation for introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU.
No functional changes.
 
> -- 
> Cheers,
> 
> David / dhildenb
> 

-- 
Sincerely yours,
Mike.