linux-kernel - Re: [PATCH v3] mmc: sdhci-of-arasan: Add shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3184c0bc-95a0-4ee2-8804-345bb30e99ac@intel.com>
Date: Mon, 16 Jun 2025 14:34:23 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Paul Alvin <alvin.paulp@....com>, <michal.simek@....com>,
	<ulf.hansson@...aro.org>
CC: <git@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] mmc: sdhci-of-arasan: Add shutdown callback

On 12/06/2025 08:41, Paul Alvin wrote:
> Implement shutdown hook to ensure proper host shutdown by using sdhci
> platform suspend. This ensure a safe transition when the Kexec utility
> calls the shutdown hook, facilitating seamless loading and booting of
> a new kernel from the currently running one.

Still sounds a bit unnecessary.  What happens if this is not done?

> 
> Signed-off-by: Paul Alvin <alvin.paulp@....com>
> ---
> 
> Changes in v3:
> - Updated commit description.
> 
> Changes in v2:
> - Make use of platform suspend instead of driver suspend as driver
>   suspend will only get defined if PMC_SLEEP is configured which
>   results in build failure if it is not configured.
> - Updated commit description.
> 
>  drivers/mmc/host/sdhci-of-arasan.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 8c29676ab662..4abdad3c4e5b 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -2056,6 +2056,11 @@ static void sdhci_arasan_remove(struct platform_device *pdev)
>  	clk_disable_unprepare(clk_ahb);
>  }
>  
> +static void sdhci_arasan_shutdown(struct platform_device *pdev)
> +{
> +	sdhci_pltfm_suspend(&pdev->dev);
> +}
> +
>  static struct platform_driver sdhci_arasan_driver = {
>  	.driver = {
>  		.name = "sdhci-arasan",
> @@ -2065,6 +2070,7 @@ static struct platform_driver sdhci_arasan_driver = {
>  	},
>  	.probe = sdhci_arasan_probe,
>  	.remove = sdhci_arasan_remove,
> +	.shutdown = sdhci_arasan_shutdown,
>  };
>  
>  module_platform_driver(sdhci_arasan_driver);