linux-kernel - Re: [PATCH v10 2/5] rust: Rename AlwaysRefCounted to RefCounted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLgh4H8mVjjPT3ya9Seop+xnzrwMEfSWF7eEcT3e16oV5FQ@mail.gmail.com>
Date: Mon, 16 Jun 2025 14:13:44 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Oliver Mangold <oliver.mangold@...me>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/5] rust: Rename AlwaysRefCounted to RefCounted

On Mon, Jun 16, 2025 at 1:56 PM Oliver Mangold <oliver.mangold@...me> wrote:
>
> On 250502 1132, Alice Ryhl wrote:
> > On Fri, May 02, 2025 at 09:02:37AM +0000, Oliver Mangold wrote:
> > > AlwaysRefCounted will become a marker trait to indicate that it is allowed
> > > to obtain an ARef<T> from a `&T`, which cannot be allowed for types which
> > > are also Ownable.
> > >
> > > Signed-off-by: Oliver Mangold <oliver.mangold@...me>
> > > Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
> >
> > >  // SAFETY: All instances of `Request<T>` are reference counted. This
> > > -// implementation of `AlwaysRefCounted` ensure that increments to the ref count
> > > +// implementation of `RefCounted` ensure that increments to the ref count
> > >  // keeps the object alive in memory at least until a matching reference count
> > >  // decrement is executed.
> >
> > It looks like "keeps" now fits on the previous line. I would reflow all
> > text in this patch.
>
> Say, this means you have a tool to do that automatically for you? I'm doing
> it by hand currently.

In vim you can do it by selecting the text and typing gq.

Alice