linux-kernel - Re: [PATCH v8 0/2] riscv: pwm: sophgo: add pwm support for CV1800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cr6gtizsg5qk5ggpnlbjxon4rph4c2g6wboem4e7bbjhmxxifm@v5kqrwr4i76a>
Date: Mon, 16 Jun 2025 15:05:07 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Thomas Bonnefille <thomas.bonnefille@...tlin.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Miquèl Raynal <miquel.raynal@...tlin.com>, 
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, sophgo@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Jingbao Qiu <qiujingbao.dlmu@...il.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v8 0/2] riscv: pwm: sophgo: add pwm support for CV1800

Hello,

On Tue, May 27, 2025 at 06:43:06AM +0800, Inochi Amaoto wrote:
> On Mon, May 26, 2025 at 06:31:42PM +0200, Uwe Kleine-König wrote:
> > On Fri, May 09, 2025 at 08:14:57PM +0800, Inochi Amaoto wrote:
> > > On Fri, May 09, 2025 at 11:45:42AM +0200, Thomas Bonnefille wrote:
> > > > The Sophgo CV1800 chip provides a set of four independent
> > > > PWM channel outputs.
> > > > This series adds PWM controller support for Sophgo cv1800.
> > > > 
> > > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> > > > [Thomas since v8]
> > > > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
> > > > ---
> > > 
> > > As now we have pwm support for SG2042, I suggest sharing driver code and
> > > binding file with SG2042.
> > 
> > How does the two relate? Is CV1800 the same as SG2042? I'd like to know
> > before I spend time reviewing a driver that is better spent elsewhere.
> > 
> 
> IIRC the pwm SG2044 is based on it on CV1800. And they both share some
> common logic with SG2042, like setting PERIOD register. So I request a
> merge for it.

To make this explict: Without having looked into the details, I agree
and so will discard this patch set from the set of waiting patches in
patchwork.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)