linux-kernel - Re: [PATCH 3/4] dt-bindings: phy: airoha: Document support for AN7583 PCIe PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68517436.050a0220.b9e1c.ed09@mx.google.com>
Date: Tue, 17 Jun 2025 15:57:09 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: phy: airoha: Document support for
 AN7583 PCIe PHY

On Mon, Jun 09, 2025 at 05:51:10PM +0100, Conor Dooley wrote:
> On Fri, Jun 06, 2025 at 09:22:04PM +0200, Christian Marangi wrote:
> > Document support for AN7583 PCIe PHY used to make the Gen3 PCIe port
> > work. Add the rwquired register to configure the PCIe PHY and provide an
> > example for it.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> >  .../bindings/phy/airoha,an7583-pcie-phy.yaml  | 72 +++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/airoha,an7583-pcie-phy.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/airoha,an7583-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/airoha,an7583-pcie-phy.yaml
> > new file mode 100644
> > index 000000000000..93252092c2e3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/airoha,an7583-pcie-phy.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/airoha,an7583-pcie-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Airoha AN7583 PCI-Express PHY
> > +
> > +maintainers:
> > +  - Christian Marangi <ansuelsmth@...il.com>
> > +
> > +description:
> > +  The PCIe PHY supports physical layer functionality for PCIe Gen2/Gen3 port.
> > +
> > +properties:
> > +  compatible:
> > +    const: airoha,an7583-pcie-phy
> > +
> > +  reg:
> > +    items:
> > +      - description: PCIE G3 analog base address
> > +      - description: PCIE G3 PMA base address
> > +      - description: PCIE QPhy analog base address
> > +      - description: PCIE QPhy PMA base address
> > +      - description: PCIE QPhy diagnostic base address
> > +      - description: PCIE detection time base address
> > +      - description: PCIE Rx AEQ base address
> > +
> > +  reg-names:
> > +    items:
> > +      - const: g3-ana
> > +      - const: g3-pma
> > +      - const: qp-ana
> > +      - const: qp-pma
> > +      - const: qp-dig
> > +      - const: xr-dtime
> > +      - const: rx-aeq
> > +
> > +  "#phy-cells":
> > +    const: 0
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +  - "#phy-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/phy/phy.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        phy@...80000 {
> > +            compatible = "airoha,an7583-pcie-phy";
> > +            #phy-cells = <0>;
> > +            reg = <0x0 0x1fc7f000 0x0 0xfff>,
> > +                  <0x0 0x1fc7e000 0x0 0xfff>,
> > +                  <0x0 0x1fa5f000 0x0 0xff>,
> > +                  <0x0 0x1fa5e000 0x0 0x8ff>,
> > +                  <0x0 0x1fa5a000 0x0 0x3ff>,
> > +                  <0x0 0x1fc30044 0x0 0x4>,
> > +                  <0x0 0x1fc35030 0x0 0x4>;
> 
> Can you explain please why you have so many reg regions, some of which
> are directly beside one another? Why is one (or more) larger region(s)
> not viable here? Are some of these coming from a syscon that is not
> modelled or are there other devices sharing in between?
>

It's to keep consistency with the documentation and how stuff is
modelled in the SDK driver. The single region defined reflect real
register space. In the middle they are invalid register that might cause
system stall if read/written.

Also this is to keep consistency with the en7581 pcie phy driver.

Is it really that bad ? :(

> > +            reg-names = "g3-ana", "g3-pma",
> > +                        "qp-ana", "qp-pma", "qp-dig",
> > +                        "xr-dtime", "rx-aeq";
> > +        };
> > +    };
> > -- 
> > 2.48.1
> > 



-- 
	Ansuel