linux-kernel - Re: [RFC RESEND v10 03/14] irq & spin_lock: Add counted interrupt disabling/enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617101408.6dde6324@gandalf.local.home>
Date: Tue, 17 Jun 2025 10:14:08 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Joel Fernandes <joelagnelf@...dia.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Peter Zijlstra
 <peterz@...radead.org>, Lyude Paul <lyude@...hat.com>,
 rust-for-linux@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
 linux-kernel@...r.kernel.org, Daniel Almeida
 <daniel.almeida@...labora.com>, Ingo Molnar <mingo@...hat.com>, Juri Lelli
 <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Ben Segall
 <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Valentin Schneider
 <vschneid@...hat.com>, Will Deacon <will@...nel.org>, Waiman Long
 <longman@...hat.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor
 <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn
 Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
 <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
 <dakr@...nel.org>, David Woodhouse <dwmw@...zon.co.uk>, Jens Axboe
 <axboe@...nel.dk>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 NeilBrown <neilb@...e.de>, Caleb Sander Mateos <csander@...estorage.com>,
 Ryo Takakura <ryotkkr98@...il.com>, K Prateek Nayak
 <kprateek.nayak@....com>
Subject: Re: [RFC RESEND v10 03/14] irq & spin_lock: Add counted interrupt
 disabling/enabling

On Mon, 16 Jun 2025 14:37:49 -0400
Joel Fernandes <joelagnelf@...dia.com> wrote:

> At first glance that makes sense. Was there some concern about overhead? Me and
> Steve did some experiments back in the day where we found local_irq_disable()
> can be performance-sensitive, but we were adding tracers/tracing which
> presumably can be higher overhead than what this series is doing.
> 

The performance overhead was because, I believe, we added a function call
to the local_irq_disable, which can add quite a bit of overhead.

> thanks,
> 
>  - Hiek

I like the new sig! (Right hand off by one?) You should keep it ;-)

-- Steve