linux-kernel - Re: [PATCH 20/43] sched/smp: Make SMP unconditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250617103827.25ee218e@gandalf.local.home>
Date: Tue, 17 Jun 2025 10:38:27 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Francesco Ansanelli <francians@...il.com>
Cc: mingo@...nel.org, bigeasy@...utronix.de, dietmar.eggemann@....com,
 juri.lelli@...hat.com, linux-kernel@...r.kernel.org, mgorman@...e.de,
 peterz@...radead.org, sshegde@...ux.ibm.com, tglx@...utronix.de,
 torvalds@...ux-foundation.org, vincent.guittot@...aro.org,
 vschneid@...hat.com
Subject: Re: [PATCH 20/43] sched/smp: Make SMP unconditional

On Tue, 17 Jun 2025 06:43:00 +0200
Francesco Ansanelli <francians@...il.com> wrote:

> I hope this is the right way of reaching you.
> I was reviewing the patch in subject and noticed a possible error:
> 
> -#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) &&
> \
> - (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH)))
> +#if defined(CONFIG_RT_GROUP_SCHED) || defined(CONFIG_FAIR_GROUP_SCHED)
> 
> I think it should be:
> 
> +#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) &&
> defined(CONFIG_CFS_BANDWIDTH))

Nope, it was right as is. The "Make SMP unconditional" means CONFIG_SMP is
now always defined. The original was:

#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) && \
 (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH)))

With defined(CONFIG_SMP) always true, the:

  (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH))

is always true as well, which makes it:

#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) && (true))

Or just:

#if defined(CONFIG_RT_GROUP_SCHED) || defined(CONFIG_FAIR_GROUP_SCHED)

-- Steve