linux-kernel - Re: NULL pointer dereference in igen6_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617145150.GCaFGBBvUvkrtpO9j_@fat_crate.local>
Date: Tue, 17 Jun 2025 16:51:50 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: "Luck, Tony" <tony.luck@...el.com>,
	Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>,
	"open list:EDAC-IGEN6" <linux-edac@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: NULL pointer dereference in igen6_probe - 6.16-rc2

On Tue, Jun 17, 2025 at 02:09:42PM +0000, Zhuo, Qiuxu wrote:
> In the 10nm_edac driver for Intel Xeon server, 'cfg' is non-const, and the field
> 'cfg->ddr_imc_num' [1] is overwritten with the number of detected DDR memory
> controllers at runtime.
> 
> Reverting 'cfg' in this igen6_edac driver to non-const, allowing it to be set
> with the actual number of detected memory controllers seems reasonable.

Question is: is that something the driver should allow? Detecting more memory
controllers but enabling less. How can that even happen?

> After that then applying Boris' fix above is the simplest way to resolve the 
> issue. 😊

Right, just prepare a proper patch, please, so that Marek can test and
confirm.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette