linux-kernel - Re: [PATCH] function_graph: Fix off-by-one error in buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250617110245.5b68ab97@gandalf.local.home>
Date: Tue, 17 Jun 2025 11:02:45 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Artem Sadovnikov <a.sadovnikov@...ras.ru>
Cc: linux-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] function_graph: Fix off-by-one error in buffer size

On Tue, 17 Jun 2025 11:00:17 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 17 Jun 2025 11:19:06 +0000
> Artem Sadovnikov <a.sadovnikov@...ras.ru> wrote:
> 
> > The comment above buffer mentions sign, 10 bytes width for number and null
> > terminator, but buffer itself isn't large enough to hold that much data.
> > 
> > This is a cosmetic change, since PID cannot be negative, other than -1.  
> 
> Right, where I'll change the subject as that makes it look like this is a
> real bug.

Can your resend and Cc linux-trace-kernel@...r.kernel.org otherwise it will
not get into the patchwork queue.

Rename the Subject to:

 fgraph: Make pid_str size match the comment

Thanks!

-- Steve