linux-kernel - Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFGPVPDKGLOIEucg@x1.local>
Date: Tue, 17 Jun 2025 11:52:52 -0400
From: Peter Xu <peterx@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Ujwal Kundur <ujwal.kundur@...il.com>, shuah@...nel.org,
	jackmanb@...gle.com, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global
 vars into struct

On Mon, Jun 16, 2025 at 05:26:18PM -0700, Andrew Morton wrote:
> On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur <ujwal.kundur@...il.com> wrote:
> 
> > Refactor macros and non-composite global variable definitions into a
> > struct that is defined at the start of a test and is passed around
> > instead of relying on global vars.
> 
> Well I guess that's nicer.
> 
> >  5 files changed, 616 insertions(+), 542 deletions(-)
> 
> It needs to be!
> 
> Thanks, I'll queue it for testing while Peter thinks about it :)

I didn't pay much attention on this one as I saw Brandan was actively
reviewing it, which was great.

This is definitely an improvement to the test.  Thanks both!

-- 
Peter Xu