linux-kernel - Re: [PATCH v2] lib/crypto: explicitly include <linux/export.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250617032639.GC8289@sol>
Date: Mon, 16 Jun 2025 20:26:39 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, "Jason A . Donenfeld " <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2] lib/crypto: explicitly include <linux/export.h>

On Fri, Jun 13, 2025 at 11:48:14AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Fix build warnings with W=1 that started appearing after
> commit a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1").
> 
> While at it, also sort the include lists alphabetically.  (Keep
> asm/irqflags.h last, as otherwise it doesn't build on alpha.)
> 
> This handles all of lib/crypto/, but not arch/*/lib/crypto/.  The
> exports in arch/*/lib/crypto/ will go away when the code is properly
> integrated into lib/crypto/ as planned.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> v2: keep asm/irqflags.h last, to avoid build error on alpha
>     (https://lore.kernel.org/all/202506140001.CtqYqDPn-lkp@intel.com/)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric