linux-kernel - Re: [PATCH] x86/sgx: Use ENCLS mnemonic in <kernel/cpu/sgx/encls.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFULd4YzC1xe0mVmJhWAk=sxhsctpZUxQGyRKccW-VF7OhkjKg@mail.gmail.com>
Date: Tue, 17 Jun 2025 18:20:49 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Dave Hansen <dave.hansen@...el.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, linux-sgx@...r.kernel.org, x86@...nel.org, 
	linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...ux.intel.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>, 
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86/sgx: Use ENCLS mnemonic in <kernel/cpu/sgx/encls.h>

On Tue, Jun 17, 2025 at 5:01 PM Dave Hansen <dave.hansen@...el.com> wrote:
>
> On 6/17/25 07:44, Jarkko Sakkinen wrote:
> > I don't really see how this is that useful. That said, f a bug fix or
> > feature used encls mnemonic, I'd had no problems with acking it.
>
> It's not _that_ useful.
>
> But old assemblers that we still want to use *NEVER* have support for
> newfanlged instructions, so we always add new instructions with ".byte".
> Then, a few years down the road when we've moved to just old assemblers
> instead of super old assemblers, we move to the real instruction names.

That, and the code becomes self-documenting. You don't have to scratch
your head what the .byte stream represents when reading assembly.

Uros.