linux-kernel - Re: [PATCH v6 6/6] samples: rust: add ACPI match table example to platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f29b4eba-bd79-4f74-940c-8cff65495ae0@gmail.com>
Date: Tue, 17 Jun 2025 17:39:07 +0100
From: Igor Korotin <igor.korotin.linux@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, rafael@...nel.org,
 gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, linux-acpi@...r.kernel.org,
 boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
 benno.lossin@...ton.me, a.hindborg@...nel.org, aliceryhl@...gle.com,
 tmgross@...ch.edu, lenb@...nel.org, wedsonaf@...il.com,
 viresh.kumar@...aro.org, alex.hung@....com, dingxiangfei2009@...il.com
Subject: Re: [PATCH v6 6/6] samples: rust: add ACPI match table example to
 platform driver

On 6/16/25 20:52, Danilo Krummrich wrote:
>> +kernel::acpi_device_table!(
>> +    ACPI_TABLE,
>> +    MODULE_ACPI_TABLE,
>> +    <SampleDriver as platform::Driver>::IdInfo,
>> +    [(acpi::DeviceId::new(c_str!("TEST4321")), Info(0))]
> 
> Let's use something like "SAMPLE_DRV0" instead.

Nope, that's prohibited by ACPI HID naming rules. A brief description
can be found here:
https://uefi.org/specs/ACPI/6.5/06_Device_Configuration.html.
According to section 6.1.5, ACPI IDs must be 7 or 8 characters long and
follow the format "AAA####" or "AAAA####", where A is an uppercase
letter [A–Z] and # is an uppercase letter or digit [A–Z, 0–9]. No
underscores or special characters are allowed.

The `iasl` utility throws an error if an invalid HID string is used in a
dsl file.

I could suggest on of the following:
DRV0001
DRVR0001
PDRV0001
TEST0001
TST0001

Let me know which one you'd prefer for the code and documentation.

Best Regards
Igor