linux-kernel - Re: [PATCH] serial: core: restore of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061740-sustained-linked-a845@gregkh>
Date: Tue, 17 Jun 2025 17:56:03 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Aidan Stewart <astewart@...telic.com>
Cc: "jirislaby@...nel.org" <jirislaby@...nel.org>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] serial: core: restore of_node information in sysfs

On Tue, Jun 17, 2025 at 03:46:37PM +0000, Aidan Stewart wrote:
> On Tue, 2025-06-17 at 06:44 +0200, Greg KH wrote:
> > 
> > On Mon, Jun 16, 2025 at 10:21:54AM -0600, Aidan Stewart wrote:
> > > 
> > > 
> > > +     if (IS_ENABLED(CONFIG_OF)) {
> > > +             device_set_of_node_from_dev(dev, parent_dev);
> > > +     }
> > 
> > Did this pass checkpatch.pl?
> I ran checkpatch.pl with the --strict option and I didn't get any warnings
> or errors. Is there a style issue you would like me to fix?

You should not need {} for a one line if statement.

> > And why is the if statement needed?
> I guess it's not really needed. I was trying to avoid the call for non-DT
> systems, but it should still be safe to do. I will remove it in v2.

Please do!

thanks,

greg k-h