linux-kernel - Re: NULL pointer dereference in igen6_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617182055.GHaFGyByH_B0r3fTql@fat_crate.local>
Date: Tue, 17 Jun 2025 20:20:55 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: "Luck, Tony" <tony.luck@...el.com>,
	Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>,
	"open list:EDAC-IGEN6" <linux-edac@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: NULL pointer dereference in igen6_probe - 6.16-rc2

On Tue, Jun 17, 2025 at 04:16:41PM +0000, Zhuo, Qiuxu wrote:
> The maximum number of detected memory controllers is bounded
> by the macro NUM_IMC [1]. This value is what we know as the maximum 
> possible value now.

I don't think you're answering my question:

Can this happen in real life and why was it added?

        if (lmc < res_cfg->num_imc) 
                igen6_printk(KERN_WARNING, "Expected %d mcs, but only %d detected.",
                             res_cfg->num_imc, lmc);

/me does git archeology...

Aha, I guess it can even with Intel and official fw and so on - not only
coreboot:

20e190b1c1fd ("EDAC/igen6: Skip absent memory controllers")

> I'll make a patch for Marek to test first. 

Yes, that would be the right thing to do.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette