linux-kernel - RE: [PATCH v1] gpio: mlxbf3: only get IRQ for device instance 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59073B275C027AB217C172DAC773A@MN0PR12MB5907.namprd12.prod.outlook.com>
Date: Tue, 17 Jun 2025 20:17:22 +0000
From: David Thompson <davthompson@...dia.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Shravan Ramani
	<shravankr@...dia.com>
Subject: RE: [PATCH v1] gpio: mlxbf3: only get IRQ for device instance 0

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@...ev.pl>
> Sent: Monday, June 16, 2025 3:59 AM
> To: David Thompson <davthompson@...dia.com>
> Cc: linus.walleij@...aro.org; linux-gpio@...r.kernel.org; linux-
> kernel@...r.kernel.org; Shravan Ramani <shravankr@...dia.com>
> Subject: Re: [PATCH v1] gpio: mlxbf3: only get IRQ for device instance 0
> 
> On Fri, Jun 13, 2025 at 6:35 PM David Thompson <davthompson@...dia.com>
> wrote:
> >
> > The gpio-mlxbf3 driver interfaces with two GPIO controllers, device
> > instance 0 and 1. There is a single IRQ resource shared between the
> > two controllers, and it is found in the ACPI table for device instance
> > 0.  The driver should not attempt to get an IRQ resource when probing
> > device instance 1, otherwise the following error is logged:
> >   mlxbf3_gpio MLNXBF33:01: error -ENXIO: IRQ index 0 not found
> >
> > Signed-off-by: David Thompson <davthompson@...dia.com>
> > Reviewed-by: Shravan Kumar Ramani <shravankr@...dia.com>
> > ---
> 
> This looks like a fix, does it miss the Fixes: and Cc: stable tags?
> 
> Bartosz

Hello Bartosz,

Yes, good point.  Since this patch is a fix, it should have the following tag:
	Fixes: cd33f216d241 ("gpio: mlxbf3: Add gpio driver support")

Do you want me to create a v2 with the above Fixes tag and send out,
this time including to CC:stable@...r.kernel.org?

Regards, Dave