linux-kernel - Re: [PATCH v10 2/7] reboot: hw_protection_trigger: use standardized numeric shutdown/reboot reasons instead of strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506180402.ly0g2TQe-lkp@intel.com>
Date: Wed, 18 Jun 2025 04:41:41 +0800
From: kernel test robot <lkp@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
	Sebastian Reichel <sre@...nel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Benson Leung <bleung@...omium.org>,
	Tzung-Bi Shih <tzungbi@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Mark Brown <broonie@...nel.org>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	linux-pm@...r.kernel.org,
	Søren Andersen <san@...v.dk>,
	Guenter Roeck <groeck@...omium.org>,
	Ahmad Fatoum <a.fatoum@...gutronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>,
	chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v10 2/7] reboot: hw_protection_trigger: use standardized
 numeric shutdown/reboot reasons instead of strings

Hi Oleksij,

kernel test robot noticed the following build warnings:

[auto build test WARNING on sre-power-supply/for-next]
[also build test WARNING on broonie-regulator/for-next chrome-platform/for-next chrome-platform/for-firmware-next linus/master v6.16-rc2 next-20250617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/power-Extend-power_on_reason-h-for-upcoming-PSCRR-framework/20250617-175433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20250617094945.3619360-3-o.rempel%40pengutronix.de
patch subject: [PATCH v10 2/7] reboot: hw_protection_trigger: use standardized numeric shutdown/reboot reasons instead of strings
config: hexagon-randconfig-001-20250618 (https://download.01.org/0day-ci/archive/20250618/202506180402.ly0g2TQe-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250618/202506180402.ly0g2TQe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506180402.ly0g2TQe-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/regulator/core.c:5280:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    5280 |         default:
         |         ^
   drivers/regulator/core.c:5280:2: note: insert '__attribute__((fallthrough));' to silence this warning
    5280 |         default:
         |         ^
         |         __attribute__((fallthrough)); 
   drivers/regulator/core.c:5280:2: note: insert 'break;' to avoid fall-through
    5280 |         default:
         |         ^
         |         break; 
   1 warning generated.


vim +5280 drivers/regulator/core.c

  5253	
  5254	/**
  5255	 * regulator_handle_critical - Handle events for system-critical regulators.
  5256	 * @rdev: The regulator device.
  5257	 * @event: The event being handled.
  5258	 *
  5259	 * This function handles critical events such as under-voltage, over-current,
  5260	 * and unknown errors for regulators deemed system-critical. On detecting such
  5261	 * events, it triggers a hardware protection shutdown with a defined timeout.
  5262	 */
  5263	static void regulator_handle_critical(struct regulator_dev *rdev,
  5264					      unsigned long event)
  5265	{
  5266		enum psc_reason pscr;
  5267	
  5268		if (!rdev->constraints->system_critical)
  5269			return;
  5270	
  5271		switch (event) {
  5272		case REGULATOR_EVENT_UNDER_VOLTAGE:
  5273			pscr = PSCR_UNDER_VOLTAGE;
  5274			break;
  5275		case REGULATOR_EVENT_OVER_CURRENT:
  5276			pscr = PSCR_OVER_CURRENT;
  5277			break;
  5278		case REGULATOR_EVENT_FAIL:
  5279			pscr = PSCR_REGULATOR_FAILURE;
> 5280		default:
  5281			pscr = PSCR_UNKNOWN;
  5282		}
  5283	
  5284		hw_protection_trigger(pscr,
  5285				      rdev->constraints->uv_less_critical_window_ms);
  5286	}
  5287	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki