linux-kernel - Re: [PATCH 07/14] xfs: ifdef out unused xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250617044625.GD1824@lst.de>
Date: Tue, 17 Jun 2025 06:46:25 +0200
From: Christoph Hellwig <hch@....de>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Carlos Maiolino <cem@...nel.org>,
	"Darrick J. Wong" <djwong@...nel.org>
Subject: Re: [PATCH 07/14] xfs: ifdef out unused xfs_attr events

On Mon, Jun 16, 2025 at 10:52:14AM -0400, Steven Rostedt wrote:
> On Mon, 16 Jun 2025 07:28:10 +0200
> Christoph Hellwig <hch@....de> wrote:
> 
> > On Thu, Jun 12, 2025 at 05:24:12PM -0400, Steven Rostedt wrote:
> > > From: Steven Rostedt <rostedt@...dmis.org>
> > > 
> > > Trace events can take up to 5K in memory for text and meta data per event
> > > regardless if they are used or not, so they should not be defined when not
> > > used. The events xfs_attr_fillstate and xfs_attr_refillstate are only
> > > called in code that is #ifdef out and exists only for future reference.
> > > 
> > > Ifdef out the events that go with that code and add a comment mentioning
> > > the other code.  
> > 
> > Just drop them entirely, which is what the code using them should
> > have done as well.  We can always triviall bring back code from
> > git history.
> 
> OK. But I'll only send a patch to delete the trace events. I'll let
> someone else remove the actual code.

Yeah, no need for you to fix up the other code.