linux-kernel - Re: [PATCH] dmaengine: dw: dmamux: Add NULL check in rzn1_dmamux_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <471c85c8-b49d-4fc4-991e-933cedf47a93@kernel.org>
Date: Tue, 17 Jun 2025 08:10:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charles Han <hanchunchao@...pur.com>, vireshk@...nel.org,
 andriy.shevchenko@...ux.intel.com, vkoul@...nel.org,
 miquel.raynal@...tlin.com, ilpo.jarvinen@...ux.intel.com
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: dw: dmamux: Add NULL check in
 rzn1_dmamux_route_allocate()

On 16/06/2025 12:48, Charles Han wrote:
> The function of_find_device_by_node() may return NULL if the device
> node cannot be found or CONFIG_OF is not defined, dereferencing
> it without NULL check may lead to NULL dereference.
> Add a check to verify whether the return value is NULL.
> 
> Fixes: 134d9c52fca2 ("dmaengine: dw: dmamux: Introduce RZN1 DMA router support")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>  drivers/dma/dw/rzn1-dmamux.c | 10 ++++++++--


Don't send patches for a subsystem patch by patch, but organize your
work correctly into patchset so we can reply in one thread (instead of
10) that you are fixing non-existing problems.

Best regards,
Krzysztof