linux-kernel - Re: [PATCH v5 07/11] iio: adc: ad4170: Add clock provider support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vcx+DY1T03RiLjqo6PEe0C97N3bzW1irvCe_1ZBpO_n6Q@mail.gmail.com>
Date: Tue, 17 Jun 2025 09:24:04 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, jic23@...nel.org, lars@...afoo.de, 
	Michael.Hennerich@...log.com, nuno.sa@...log.com, andy@...nel.org, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	linus.walleij@...aro.org, brgl@...ev.pl, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v5 07/11] iio: adc: ad4170: Add clock provider support

On Tue, Jun 17, 2025 at 12:11 AM David Lechner <dlechner@...libre.com> wrote:
> On 6/10/25 3:33 PM, Marcelo Schmitt wrote:

 ...

> > +             if (!device_property_read_bool(&st->spi->dev, "#clock-cells"))
>
> This isn't a flag, so device_property_present() is probably more correct.
>
> > +                     return 0;

Good catch! +1 to this, it must not be read_bool as it's not a boolean property.

-- 
With Best Regards,
Andy Shevchenko