linux-kernel - Re: [PATCH v1 2/2] Bluetooth: btnxpuart: Add support for 4M baudrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fe27c9d-4641-4aba-9e34-686a4d7f1fa8@kernel.org>
Date: Tue, 17 Jun 2025 08:43:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sherry Sun <sherry.sun@....com>,
 Neeraj Sanjay Kale <neeraj.sanjaykale@....com>,
 "marcel@...tmann.org" <marcel@...tmann.org>,
 "luiz.dentz@...il.com" <luiz.dentz@...il.com>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Amitkumar Karwar <amitkumar.karwar@....com>,
 Manjeet Gupta <manjeet.gupta@....com>
Subject: Re: [PATCH v1 2/2] Bluetooth: btnxpuart: Add support for 4M baudrate

On 17/06/2025 04:53, Sherry Sun wrote:
>> @@ -992,7 +997,7 @@ static int nxp_recv_fw_req_v1(struct hci_dev *hdev,
>> struct sk_buff *skb)
>>  			nxpdev->helper_downloaded = true;
>>  			serdev_device_wait_until_sent(nxpdev->serdev, 0);
>>  			serdev_device_set_baudrate(nxpdev->serdev,
>> -						   HCI_NXP_SEC_BAUDRATE);
>> +
>> HCI_NXP_SEC_BAUDRATE_3M);
> 
> Hi Neeraj,
> 
> Does this mean that some legacy BT chips using nxp_recv_fw_req_v1() don't support 4Mbps?
> If so, please add comments in the commit message.

If that's true this is implied by compatible and entire property should
be dropped.

Best regards,
Krzysztof