linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Add CPU scaling clock node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bceae03-33fe-4ec0-b1da-785af793dd86@quicinc.com>
Date: Tue, 17 Jun 2025 12:59:00 +0530
From: Imran Shaik <quic_imrashai@...cinc.com>
To: Taniya Das <taniya.das@....qualcomm.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@....qualcomm.com>,
        Taniya Das <quic_tdas@...cinc.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Ajit Pandey
	<quic_ajipan@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Add CPU scaling clock
 node



On 6/17/2025 12:27 PM, Taniya Das wrote:
> 
> 
> On 6/13/2025 6:40 PM, Dmitry Baryshkov wrote:
>> On Thu, Jun 12, 2025 at 03:47:21PM +0530, Taniya Das wrote:
>>> Add cpufreq-hw node to support CPU frequency scaling.
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 29 +++++++++++++++++++++++++++++
>>>  1 file changed, 29 insertions(+)
>>>
>>> +
>>> +		cpufreq_hw: cpufreq@...23000 {
>>> +			compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
>>
>> This wasn't build-tested (or was edited after being compile-tested).
> 
> This is already tested on the QCS615.
>>

Seems there is a syntax issue, could you please check?
 
- compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
+ compatible = "qcom,sc7180-cpufreq-hw", "qcom,cpufreq-hw";

>>> +			reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
>>> +			reg-names = "freq-domain0", "freq-domain1";
>>> +
>>> +			clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;
>>> +			clock-names = "xo", "alternate";
>>> +
>>> +			#freq-domain-cells = <1>;
>>> +			#clock-cells = <1>;
>>> +		};
>>> +
>>>  	};
>>>  
>>>  	arch_timer: timer {
>>>
>>> -- 
>>> 2.34.1
>>>
>>
>