linux-kernel - Re: [PATCH v2 2/4] dt-bindings: PCI: qcom,pcie-sa8775p: document link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFEb8m0snKARK90R@hovoldconsulting.com>
Date: Tue, 17 Jun 2025 09:40:34 +0200
From: Johan Hovold <johan@...nel.org>
To: Ziyue Zhang <quic_ziyuzhan@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, jingoohan1@...il.com,
	mani@...nel.org, lpieralisi@...nel.org, kwilczynski@...nel.org,
	bhelgaas@...gle.com, johan+linaro@...nel.org, vkoul@...nel.org,
	kishon@...nel.org, neil.armstrong@...aro.org, abel.vesa@...aro.org,
	kw@...ux.com, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-phy@...ts.infradead.org,
	qiang.yu@....qualcomm.com, quic_krichai@...cinc.com,
	quic_vbadigan@...cinc.com
Subject: Re: [PATCH v2 2/4] dt-bindings: PCI: qcom,pcie-sa8775p: document
 link_down reset

On Tue, Jun 17, 2025 at 10:16:15AM +0800, Ziyue Zhang wrote:
> Each PCIe controller on sa8775p includes 'link_down'reset on hardware,
> document it.

Please say something in the commit message about what this reset is used
for as well.

> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@...cinc.com>
> ---
>  .../devicetree/bindings/pci/qcom,pcie-sa8775p.yaml  | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> index e3fa232da2ca..b7cae2e556e3 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> @@ -61,11 +61,14 @@ properties:
>        - const: global
>  
>    resets:
> -    maxItems: 1
> +    items:
> +      - description: PCIe controller reset
> +      - description: link_down reset

That's not really a description, you're just repeating the "link_down"
name here. You can probably use the description you add in the comment
below.

>    reset-names:
>      items:
> -      - const: pci
> +      - const: pci # PCIe core reset
> +      - const: link_down # PCIe link down reset

Johan