linux-kernel - Re: [PATCH] Various improvements on clock abstractions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DAON8H30Y6VO.2WKLGX2Q9DORU@nvidia.com>
Date: Tue, 17 Jun 2025 16:52:02 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "onur-ozkan" <work@...rozkan.dev>, <linux-clk@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc: <mturquette@...libre.com>, <sboyd@...nel.org>, <ojeda@...nel.org>,
 <alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, <lossin@...nel.org>, <a.hindborg@...nel.org>,
 <aliceryhl@...gle.com>, <tmgross@...ch.edu>, <dakr@...nel.org>
Subject: Re: [PATCH] Various improvements on clock abstractions

On Tue Jun 17, 2025 at 5:01 AM JST, onur-ozkan wrote:
> A few changes to improve the clock abstractions and make them a little
> more idiomatic:
>
> 1. `impl Hertz` functions are now constant and compile-time evaluable.
> 2. `Hertz` conversions are now done with constant variables, which should

"constant variable" is an oxymoron. :) I think you just want to say
"constant" here.

>     make them more readable.
> 3. `con_id` is handled in a single line using `map_or` instead of using
>     nested if-else blocks.

Please split these 3 changes into 3 patches, I agree that they are
trivial but a patch should do a single thing. This makes review simpler
and allows to apply only part of the changes if e.g. one of them needs
further discussion or is rejected.

The changes in themselves look good though!