linux-kernel - Re: [PATCH] bus: moxtet: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32qyokqqrdauwzjph45cga2ypqwn4i6aa3yiusasq6syxwhxlr@e2n7zb6rip2d>
Date: Tue, 17 Jun 2025 10:00:01 +0200
From: Marek Behún <kabel@...nel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, 
	Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH] bus: moxtet: Use dev_fwnode()

Reviewed-by: Marek Behún <kabel@...nel.org>

On Wed, Jun 11, 2025 at 12:43:31PM +0200, Jiri Slaby (SUSE) wrote:
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
> 
> So use the dev_fwnode() helper.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: "Marek Behún" <kabel@...nel.org>
> ---
>  drivers/bus/moxtet.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 6c3e5c5dae10..7ce61d629a87 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -737,8 +737,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet)
>  {
>  	int i, ret;
>  
> -	moxtet->irq.domain = irq_domain_create_simple(of_fwnode_handle(moxtet->dev->of_node),
> -						      MOXTET_NIRQS, 0,
> +	moxtet->irq.domain = irq_domain_create_simple(dev_fwnode(moxtet->dev), MOXTET_NIRQS, 0,
>  						      &moxtet_irq_domain, moxtet);
>  	if (moxtet->irq.domain == NULL) {
>  		dev_err(moxtet->dev, "Could not add IRQ domain\n");
> -- 
> 2.49.0
>