linux-kernel - Re: [PATCH v6 0/5] Allow dyn MSI-X vector allocation of MANA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250616181148.2aed5dfe@kernel.org>
Date: Mon, 16 Jun 2025 18:11:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, Nipun Gupta <nipun.gupta@....com>, Yury Norov
 <yury.norov@...il.com>, Jason Gunthorpe <jgg@...pe.ca>, Jonathan Cameron
 <Jonathan.Cameron@...ei.com>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>, Kevin Tian <kevin.tian@...el.com>, Long Li
 <longli@...rosoft.com>, Thomas Gleixner <tglx@...utronix.de>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Rob Herring <robh@...nel.org>, Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>, Krzysztof Wilczy???~Dski
 <kw@...ux.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Dexuan Cui
 <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Haiyang Zhang
 <haiyangz@...rosoft.com>, "K. Y. Srinivasan" <kys@...rosoft.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Konstantin
 Taranov <kotaranov@...rosoft.com>, Simon Horman <horms@...nel.org>, Leon
 Romanovsky <leon@...nel.org>, Maxim Levitsky <mlevitsk@...hat.com>, Erni
 Sri Satya Vennela <ernis@...ux.microsoft.com>, Peter Zijlstra
 <peterz@...radead.org>, netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 Paul Rosswurm <paulros@...rosoft.com>, Shradha Gupta
 <shradhagupta@...rosoft.com>
Subject: Re: [PATCH v6 0/5] Allow dyn MSI-X vector allocation of MANA

On Wed, 11 Jun 2025 23:10:55 -0700 Shradha Gupta wrote:
> On Wed, Jun 11, 2025 at 08:54:16AM -0700, Jakub Kicinski wrote:
> > On Wed, 11 Jun 2025 07:09:44 -0700 Shradha Gupta wrote:  
> > > Changes in v6
> > >  * rebased to linux-next's v6.16-rc1 as per Jakub's suggestion  
> > 
> > I meant a branch, basically apply the patches on the v6.16-rc1 tag
> > and push it out to GitHub, kernel.org or somewhere else public.
> > Then we can pull it in and maintain the stable commit IDs.
> > No need to repost the patches, FWIW, just share the branch here
> > once you pushed it out..  
> 
> Oh, understood. Thanks for the clarity. Here is a github repo branch
> with the changes on v6.16-rc1 tag
> https://github.com/shradhagupta6/linux/tree/shradha_v6.16-rc1

The tag was good, but when I pulled it my check scripts complained:

Commit a19036b86845 ("net: mana: Allocate MSI-X vectors dynamically")
	committer Signed-off-by missing
	author email:    shradhagupta@...ux.microsoft.com
	committer email: shradhagupta@...rosoft.com
	Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>

etc. You seem to have committed the patches with a slightly different
email address. Not a huge deal but better to fix it if we can.

So please base the tag. The code can stay the same just adjust the
committer or author/signoff email addrs. We can use this as an
opportunity to add Bjorn's email.

No need to repost the code just ping here once you updated the tag.