linux-kernel - Re: [PATCH] phy: qcom: m31-eusb2: drop registration printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5aa6d6ee-0af5-4625-a616-868919ac36c7@linaro.org>
Date: Tue, 17 Jun 2025 10:20:09 +0200
From: neil.armstrong@...aro.org
To: Johan Hovold <johan+linaro@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: Kishon Vijay Abraham I <kishon@...nel.org>,
 Wesley Cheng <quic_wcheng@...cinc.com>,
 Melody Olvera <melody.olvera@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: qcom: m31-eusb2: drop registration printk

On 17/06/2025 10:04, Johan Hovold wrote:
> Drivers should generally be quiet on successful probe so drop the
> registration printk from the recently added M31 EUSB2 driver.
> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index 9f02b8a78f6e..9b987911fcdb 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -288,8 +288,6 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
>   				     "failed to get repeater\n");
>   
>   	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> -	if (!IS_ERR(phy_provider))
> -		dev_info(dev, "Registered M31 USB phy\n");
>   
>   	return PTR_ERR_OR_ZERO(phy_provider);
>   }

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>