linux-kernel - Re: [PATCH 1/1] mm/madvise: initialize prev pointer in madvise_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e174d4ae-9467-4fd7-906a-d575802aaecf@redhat.com>
Date: Tue, 17 Jun 2025 10:38:07 +0200
From: David Hildenbrand <david@...hat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Lance Yang <ioworker0@...il.com>, akpm@...ux-foundation.org,
 21cnbao@...il.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 jannh@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 Lance Yang <lance.yang@...ux.dev>
Subject: Re: [PATCH 1/1] mm/madvise: initialize prev pointer in
 madvise_walk_vmas

>>>> 	vma = vma_modify_flags_name(&vmi, *prev, ...
>>>>
>>>> We should use Fixes: then.
>>>
>>> So no we shouldn't...
>>>
>>>>
>>>>
>>>> Acked-by: David Hildenbrand <david@...hat.com>
>>>
>>> Sure? :)
>>
>> Unless I am missing something important, yes :)
> 
> This solution isn't correct as prev == NULL when prev != NULL is wholly
> incorrect.

I am not able to understand what you mean :)

I assume you mean, that we reach a point down in the callchain, where 
"prev" is supposed to be set to something proper, but it would be "NULL".

That would indeed require a different fix.

I wonder why we didn't trigger this case so far?

-- 
Cheers,

David / dhildenb