linux-kernel - Re: [PATCH v1 1/3] cgroup: add lock guard support for cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <o6i5idjcvyhkw3bgewr2qs2try2xm44wjlsfspolj7da3yc23n@g3x7wgiu3oyd>
Date: Tue, 17 Jun 2025 11:09:13 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Jemmy Wong <jemmywong512@...il.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	Waiman Long <longman@...hat.com>, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] cgroup: add lock guard support for cgroup_muetx

(typo in subject)

On Sat, Jun 07, 2025 at 12:18:39AM +0800, Jemmy Wong <jemmywong512@...il.com> wrote:
...
> @@ -5489,14 +5488,14 @@ static void css_free_rwork_fn(struct work_struct *work)
>  	}
>  }
>  
> -static void css_release_work_fn(struct work_struct *work)
> +static inline void css_release_work_fn_locked(struct work_struct *work)
>  {
>  	struct cgroup_subsys_state *css =
>  		container_of(work, struct cgroup_subsys_state, destroy_work);
>  	struct cgroup_subsys *ss = css->ss;
>  	struct cgroup *cgrp = css->cgroup;
>  
> -	cgroup_lock();
> +	guard(cgroup_mutex)();

I think this should use different name suffix than _locked to
distinguish it from traditional _locked functions that expect a lock
being held. E.g. *_locking? or __* (like __cgroup_task_count()).


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)